The changes in the GIT_DIFF primarily revolve around how traces are handled and how output directories are managed.

Notably, changes include:

• Importing dirname from node:path and writeFile, appendFile from fs/promises.
• Adding an event listener to the trace object that responds to TRACE_CHUNK events. When these events occur, the trace chunk is appended to the output trace file.
• Adding similar functionality for an output file named res.trace.md in the output directory.
• Making sure the output directory is created and cleaned (if necessary) before the tracing functionality is started.
• Removing the previously used writeText(outTrace, trace.content) that wrote the entire trace content at once.

Concerns:

• The trace writing functionality is duplicated for outTrace and res.trace.md. It would be better to abstract this into a separate function that handles trace writing given a file name and a trace object, thus not repeating code.
• The code checks if (out && trace) twice, once for outTrace and once for res.trace.md. Consolidating these might make the code easier to follow.

Suggested changes:

+ async function setupTraceWriting(trace: Trace, filename: string) {
+     await ensureDir(dirname(filename))
+     await writeFile(filename, "", { encoding: "utf-8" })
+     trace.addEventListener(
+         TRACE_CHUNK,
+         async (ev) => {
+             const tev = ev as TraceChunkEvent
+             await appendFile(filename, tev.chunk, { encoding: "utf-8" })
+         },
+         false
+     )
+ }

+ if (out) {
+     if (removeOut) await emptyDir(out)
+     await ensureDir(out)
+ }
+ if (out && trace) {
+     const ofn = join(out, "res.trace.md")
+     if (outTrace) {
+         setupTraceWriting(trace, outTrace);
+     }
+     if (ofn !== outTrace) {
+         setupTraceWriting(trace, ofn);
+     }
+ }

Overall, the changes look fine except for the noted concerns and suggested improvements. The change prioritizes writing trace chunks as they arrive instead of at the end, which could be beneficial for long-running processes. However, make sure to test these changes thoroughly to ensure that the trace writing functionality works as expected.

Concerns aside, LGTM 🚀

generated by pr-review